On 12/10/2011 12:45 PM, Rafał Miłecki wrote: > 2011/12/9 Franky Lin <frankyl@xxxxxxxxxxxx>: >> From: Arend van Spriel <arend@xxxxxxxxxxxx> >> >> The BCMA header only had definitions for 32-bit register access. Used >> those as a template for the 16-bit flavour. Also changed them to inline >> functions to be on the safe side. As offset parameter is used twice there >> would be a problem when used like this: bcma_set32(core, offset++, val); >> > > What is an advantage of static inline over define? > Hi Rafał, Apart from the example given in the commit message the CodingStyle documentation states a preference for inline functions. One advantage I can come up with is type checking by the compiler. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html