Hi Larry,
On 12/06/2011 12:44 AM, Larry Finger wrote:
> On 12/05/2011 04:19 PM, Hauke Mehrtens wrote:
>> --- a/drivers/ssb/driver_pcicore.c
>> +++ b/drivers/ssb/driver_pcicore.c
>> @@ -517,10 +517,14 @@ static void
>> ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc)
>>
>> static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore
>> *pc)
>> {
>> - ssb_pcicore_fix_sprom_core_index(pc);
>> + struct ssb_device *pdev = pc->dev;
>> + struct ssb_bus *bus = pdev->bus;
>> +
>> + if (bus->bustype == SSB_BUSTYPE_PCI)
>> + ssb_pcicore_fix_sprom_core_index(pc);
>>
>> /* Disable PCI interrupts. */
>> - ssb_write32(pc->dev, SSB_INTVEC, 0);
>> + ssb_write32(pdev, SSB_INTVEC, 0);
>
> As bus == pc->dev->bus is only used once, why bother to create it? If
> you were to change that, then pdev == pc->dev is only used once. Any
> real reason to change the lines above?
Not really, I will send a v2.
Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
