> > Those length restrictions are completely bogus, but they're also
> > unnecessary since this data is output data only so you aren't using the
> > policy anywhere anyway.
> Should I completely skip adding it to the policy then or just ommit the length
> restriction?
Just don't add the policy, I don't see it adding any value. The format
should be documented well enough in the header file so userspace can
understand it without the policy.
(Also note that I was referring to using a bogus length constant -- you
were saying each string here can be as long as a 802.11 frame)
> > Oh so that's supposed to be an array -- there's no way to tell this from
> > the header files. It's acceptable, but please give it an explicit
> > length.
> Ok, I haven't seen any devices with more than 2 possible antenna configuation
> profiles (horizontal/vertical, built-in/external) so far, so giving the array a
> fixed length of 4 should be fine for now.
I don't think doing a fixed length is useful -- just add a variable
describing the length.
johannes
--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
