Search Linux Wireless

Re: iwlwifi: kernel panic if try to open tid with large index (>=8)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-12-02 at 07:01 -0800, wwguy wrote:
> On Fri, 2011-12-02 at 01:11 -0800, Johannes Berg wrote:
> > On Thu, 2011-12-01 at 23:29 -0500, Nikolay Martynov wrote:
> > > Hi.
> > > 
> > >   I have an intel 5300 card running on latest compat-wireless.
> > >   If I do:
> > > echo "tx start 8" >
> > > /sys/kernel/debug/ieee80211/phy0/netdev\:wlan1/stations/XX\:XX\:XX\:XX\:XX\:XX/agg_status
> > 
> > Yikes. I think mac80211 should just reject that since it will never put
> > traffic into that TID anyway.
> > 
> Johannes, are you going to help fix that :-)

I *think* this is the right fix. Do you agree? It fixes it for sure --
but does it really not have any side effects? I'm pretty sure it doesn't
since I looked at all the code just now ...

johannes

---
 drivers/net/wireless/iwlwifi/iwl-commands.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/wireless/iwlwifi/iwl-commands.h	2011-12-02 21:12:01.000000000 +0100
+++ b/drivers/net/wireless/iwlwifi/iwl-commands.h	2011-12-02 21:12:02.000000000 +0100
@@ -814,7 +814,7 @@ struct iwl_qosparam_cmd {
 #define	IWLAGN_STATION_COUNT	16
 
 #define	IWL_INVALID_STATION 	255
-#define IWL_MAX_TID_COUNT	9
+#define IWL_MAX_TID_COUNT	8
 
 #define STA_FLG_TX_RATE_MSK		cpu_to_le32(1 << 2)
 #define STA_FLG_PWR_SAVE_MSK		cpu_to_le32(1 << 8)


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux