Hi, > We have observed memory leaks because of ampdu tx pending queue not > being freed before destroying the station info. In > '__sta_info_destroy' when we attempt the destroy the ampdu sessions > in 'ieee80211_sta_tear_down_BA_sessions', the driver calls > 'ieee80211_stop_tx_ba_cb_irqsafe' to delete the ampdu structures > (tid_tx) and splice the pending queues and this job gets queued in > sdata workqueue. > > However, the sta entry can get destroyed before the above work gets > scheduled and hence the race. Purging the queues and freeing the > tid_tx would avoid the leak, but I wanted to get your thoughts before > attempting to fix this cleanly. Yeah ... the interesting part is whether we want drivers to be able to deal with a station being removed while an aggregation stop is still pending? Otherwise we have to somehow postpone the full destruction until the aggregation stop completes? Other than that I have no concerns I guess. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
