On Mon, 2011-11-28 at 21:27 -0500, Nikolay Martynov wrote:
> Currently code allows three (HT_AGG_MAX_RETRIES) unanswered addba
> requests. When this limit is reached aggregation is turned off for
> given TID permanently. This doesn't seem right: three requests is
> not that much, some 'blackout' can happen, but effect of it affects
> whole connection indefinitely.
> This patch adds a period of time (1 minute) after which counter of
> sent addba requests is reset so addba requests can be sent again.
> The traffic impact should be negligible, but connection will be more
> stable.
Conceptually, this seems OK to me, although on broken APs it might mean
connection stalls every minute, not sure how desirable that is?
> - /* we have tried too many times, receiver does not want A-MPDU */
> if (sta->ampdu_mlme.addba_req_num[tid] > HT_AGG_MAX_RETRIES) {
> - ret = -EBUSY;
> - goto err_unlock_sta;
> + unsigned int timestamp = jiffies_to_msecs(jiffies);
> + if (timestamp - sta->ampdu_mlme.last_addba_req_time[tid] >
> + HT_AGG_RETRIES_PERIOD) {
this logic is confusing -- why ms? jiffies should be absolutely OK for
minute-long timeouts.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
