2011/11/28 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Mon, 2011-11-28 at 14:34 +0200, Emmanuel Grumbach wrote: >> On Mon, Nov 28, 2011 at 10:16, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Mon, 2011-11-28 at 08:35 +0200, Emmanuel Grumbach wrote: >> > >> >> > /* >> >> > * addba_resp_timer may have fired before we got here, and >> >> > * caused WANT_STOP to be set. If the stop then was already >> >> > * processed further, STOPPING might be set. >> >> > */ >> >> > >> >> > >> >> > Did you notice that I moved this code to after the dialog token check? >> >> > >> >> >> >> Don't you think we should also send a delBA ? The AP thinks we will Tx >> >> in Agg and basically we are now out of sync. >> > >> > We do, during the timer stop path, afaict. >> > >> >> Yes, but obviously the AP didn't hear it since it sent the addBA resp. >> IMHO, we should send it again. > > I don't think so? This is addressing a race between the timer & > receiving the frame, so typically the delBA would not have gone out yet. IMHO if we hit the fact that timer has already gone off and we got addba this normally means that we did send dellba. But it just didn't have a chance to reach remote side before addba left if. On the other hand, even if other side doesn't get dellba eventually (~5 seconds) it'll timeout rx session and we come to sync again. The whole timer-vs-addba race doesn't happen that often, so this seems acceptable. -- Truthfully yours, Martynov Nikolay. Email: mar.kolya@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
