Search Linux Wireless

Re: [PATCH] compat-wireless: adapt moving brcm80211 to main area

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 24, 2011 at 8:13 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote:
> On 11/23/2011 11:42 PM, Sedat Dilek wrote:
>> On Thu, Oct 13, 2011 at 4:16 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote:
>>> brcm80211 is no staging driver any more and can be found in the main
>>> area where all the other wireless drivers are now. There where some
>>> changes needed for the move.
>>> And BRCMFMAC does not depend on WEXT any more so remove that from
>>> config.
>>> BRCMFMAC does not build with kernel < 2.6.29, because
>>> ndev->netdev_ops = NULL and ndev->netdev_ops == &brcmf_netdev_ops_pri
>>> are not supported by the backport code for netdev_ops.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
>>> ---
>> [...]
>>> --- a/scripts/driver-select
>>> +++ b/scripts/driver-select
>> [...]
>>> -       brcm80211)
>>> +       brcmsmac)
>>> +               disable_staging
>>> +               disable_bt_usb_ethernet_var
>>> +               select_drivers          CONFIG_BRCMUTIL CONFIG_BRCMFMAC
>>> +               select_brcm80211_driver CONFIG_BRCMSMAC
>>> +               ;;
>>
>> On IRC someone reported problems building brcmsmac.ko, while trying to
>> help I fell over this:
>> Shouldn't that be CONFIG_BRCM*S*MAC in select_drivers line?
>> ( Just FYI: The guy tried building linux-2.6.39 with
>> compat-wireless-3.2-rc1-1.tar.bz2 )
> Yes just CONFIG_BRCM*S*MAC should be selected there, but it does not
> cause any problems if the wrong Broadcom driver is selected there,
> because select_drivers just changes something in
> drivers/net/wireless/Makefile and not
> drivers/net/wireless/brcm80211/Makefile. The select_drivers line just
> makes the compiler also use drivers/net/wireless/brcm80211/Makefile.
> select_brcm80211_driver selects the actual Broadcom driver to build.
>>

Thanks for the explanations.
The guy also reported, this trivial typo is still present in
compat-wireless 3.2-rc1, so you will fix it?
( Just out of curiosity: "[PATCH] compat: add config var for CORDIC
and CRC8" might be the real fix the guy was looking for? )

- Sedat -

>> - Sedat -
>>
>>> +       brcmfmac)
>>> +               disable_staging
>>>                disable_bt_usb_ethernet_var
>>> -               select_driver           CONFIG_NOTHING
>>> +               select_drivers          CONFIG_BRCMUTIL CONFIG_BRCMFMAC
>>> +               select_brcm80211_driver CONFIG_BRCMFMAC
>>>                ;;
>>>        zd1211rw)
>>>                select_driver           CONFIG_COMPAT_ZD1211RW
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux