Search Linux Wireless

Re: [RFC v2 1/8] cfg80211 and nl80211: mesh power mode config parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-11-21 at 18:40 +0400, Ivan Bezyazychnyy wrote:
> According to IEEE80211s standard a mesh STA maintains a mesh power mode
> for non-peer mesh STAs. Non-peer mesh power mode is a mesh configuration
> parameter so it should be presented in mesh_config structure. Possible
> values for mesh power mode are presented in nl80211_mesh_power_mode
> enumeration. These modes are active, light sleep and deep sleep.

This patch seems a bit strange to me because it adds an nl80211 enum
without an attribute it can be carried in.

> @@ -765,6 +765,8 @@ struct mesh_config {
>  	u16 dot11MeshMaxPeerLinks;
>  	u8  dot11MeshMaxRetries;
>  	u8  dot11MeshTTL;
> +	/* non-peer mesh power save mode */
> +	u8 power_mode;

You're later using casts etc -- shouldn't this be the enum-typed
variable?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux