On Thu, Nov 24, 2011 at 11:50 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxx> wrote: > On Thu, Nov 24, 2011 at 11:44 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Wed, 2011-11-23 at 10:40 -0500, Luis R. Rodriguez wrote: >>> It is useful to apply reguatory settings immediately. We already >>> handle applying regulatory hints immediatey for most hints but >>> for user hints and country IE hints we want to kick hardware >>> immediately to make these changes take effect. This adds supports >>> to let us kick hardware to make the changes take effect as soon >>> as possible. >> >> Can't say I like this -- wouldn't we rather call the regulatory update >> callback or so? > > I'm not a fan either, at first I considered doing that on the > reg_notifier() but then that also means every driver must implement a > reg_notifier() callback, or a new reg_apply() callback. If we do it > within cfg80211 it means all drivers get this for free and that was > the tradeoff I wanted to review through these RFCs. Unfortunately > setting the tx power was the only thing I saw cfg80211 could do right > now. > > I'm still "meh" about this too. I'm willing to give up on the complexity of this given that we *will* eventually apply the settings after a scan, etc. The gains seem to be small for what we would need to do. If we're happy to live without the optimization I can just document it to ensure everyone knows that the power stuff won't apply *immediately* but it will happen eventually and typically this is soon enough. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
