Search Linux Wireless

RE: [PATCH] mac80211: fix TX warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> Emmanuel reported that my previous patches to enable
> handing all fragments to drivers at once triggered
> the warning that the SKB queue wasn't empty. This is
> happening when we actually queue up some frames and
> don't hand them to the driver (queues are stopped).
> 
> The reason for it is that my code that splices the
> frame(s) over to the pending queue didn't re-init
> the local queue, so skb_queue_empty() was false. Fix
> this by using the _init versions of the splicing.
> 
> Also, convert the warning to WARN_ON_ONCE.
> 
> Reported-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> ---

Seems to be working - need to test it a bit more though (not sure it will be before next week though)

Thanks !
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux