On Sun, 2011-11-20 at 21:22 -0500, Nikolay Martynov wrote: > From: kolya <mar.kolya@xxxxxxxxx> > > --- Same comment as on patch 2, but additionally: please make a short & concise subject line and explain the change in proper text in the commit log. > @@ -689,6 +716,8 @@ void ieee80211_stop_tx_ba_cb(struct ieee80211_vif *vif, u8 *ra, u8 tid) > * more. > */ > > + del_timer_sync(&tid_tx->session_timer); > + > ieee80211_agg_splice_packets(local, tid_tx, tid); This is a deadlock waiting to happen. > @@ -778,6 +807,10 @@ void ieee80211_process_addba_resp(struct ieee80211_local *local, > ieee80211_agg_tx_operational(local, sta, tid); > > sta->ampdu_mlme.addba_req_num[tid] = 0; > + > + if (tid_tx->timeout) > + mod_timer(&tid_tx->session_timer, TU_TO_EXP_TIME(tid_tx->timeout)); > + line breaks please johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
