On Fri, Nov 18, 2011 at 05:58:28PM -0500, Pavel Roskin wrote: > On Fri, 18 Nov 2011 09:22:03 +0100 > Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote: > > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > I think this particular change would make the code less readable. It's > one thing to replace TABLE with TBL, but S_ can be anything - signed, > special, settable, stable... > > > - set_bit(STATUS_RF_KILL_HW, &il->status); > > + set_bit(S_RF_KILL_HW, &il->status); Should be obvious since we modify il->status > You may want to replace RF_KILL with RFKILL if you are desperate to > shorten variable names. Good idea :-) Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html