Hi,
2011/11/21 Mohammed Shafi <shafi.wireless@xxxxxxxxx>:
> instead of doing checks like the above , can we just prevent
> ath_ani_calibrate being not executed at all by doing something like
> this, please verify if i had missed something
Please see my response to [PATCH 0/4].
Before my patch the 'ath_ani_calibrate' was executed for all
devices. But for certain devices I think the intent was to not execute
'ath9k_hw_ani_monitor' ('ANI-ANI' from my previous email) and execute
everything else.
Considering this your patch seems wrong since it'll disable
'ath_ani_calibrate' completely for certain devices.
Please let me know if I'm missing something.
Thanks.
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c
> b/drivers/net/wireless/ath/ath9k/init.c
> index e046de9..e0ebccd 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -500,7 +500,9 @@ static void ath9k_init_misc(struct ath_softc *sc)
> {
> struct ath_common *common = ath9k_hw_common(sc->sc_ah);
> int i = 0;
> - setup_timer(&common->ani.timer, ath_ani_calibrate, (unsigned long)sc);
> +
> + if (sc->sc_ah->config.enable_ani)
> + setup_timer(&common->ani.timer, ath_ani_calibrate,
> (unsigned long)sc);
>
> sc->config.txpowlimit = ATH_TXPOWER_MAX;
--
Truthfully yours,
Martynov Nikolay.
Email: mar.kolya@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
