Search Linux Wireless

Re: [PATCH 02/13] ath5k: Maintain PISR snapshot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



.. replying to this after having not slept for > 24 hours, thanks to
being in transit between the US and Western Australia..

On 20 November 2011 15:56, Nick Kossifidis <mickflemm@xxxxxxxxx> wrote:
> Since we dont read a snapshot of the interrupt
> registers it might be possible to get a new interrupt
> while reading them. In this case we should make sure
> that we clear all SISR bits we get from PISR.

Just to be clear, you _shouldn't_ clear the secondary status mask bit
in the primary status register when you write back 1's to the primary
ISR.
Clear the bits that you read in the secondary status registers. If you
clear the relevant bit in the primary status register then you may
also skip perfectly valid interrupts.

You don't need to check the secondary registers and the primary ISR
bits for consistency. Just read what I did in freebsd-head :
src/sys/dev/ath/ath_hal/ar5416/ar5416_interrupts.c . it works fine.


Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux