On Fri, 2011-11-18 at 16:02 -0800, Greg KH wrote:
> 3.1-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> [This patch is supposed to be applied in 3.1 (and maybe older) branches only.]
>
> New kernels support newer firmware that users may try to incorrectly use
> with older kernels. Display error and explain the problem in such a case
>
> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> ---
> drivers/net/wireless/b43/main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -2508,6 +2508,13 @@ static int b43_upload_microcode(struct b
> b43_print_fw_helptext(dev->wl, 1);
> err = -EOPNOTSUPP;
> goto error;
> + } else if (fwrev >= 598) {
> + b43err(dev->wl, "YOUR FIRMWARE IS TOO NEW. Support for "
> + "firmware 598 and up requires kernel 3.2 or newer. You "
> + "have to install older firmware or upgrade kernel.\n");
> + b43_print_fw_helptext(dev->wl, 1);
> + err = -EOPNOTSUPP;
> + goto error;
[...]
Again, I strongly object to this way of handling the incompatibility.
The revision check is fine, but the solution must be to assign a
different filename for the newer revisions. The changes to 3.0/3.1
should be deferred until this is resolved.
Ben.
--
Ben Hutchings
The world is coming to an end. Please log off.
Attachment:
signature.asc
Description: This is a digitally signed message part
