On Fri, Nov 18, 2011 at 18:12, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2011-11-10 at 11:28 +0200, Arik Nemtsov wrote:
>> Allow setting a probe response template for an interface operating in
>> AP mode. Low level drivers are notified about changes in the probe
>> response template and are able to retrieve a copy of the current probe
>> response. This data can, for example, be uploaded to hardware as a
>> template.
>
>> +static int ieee80211_set_probe_resp(struct ieee80211_sub_if_data *sdata,
>> + u8 *resp, size_t resp_len)
>> +{
>> + struct sk_buff *new, *old;
>> +
>> + if (!resp || !resp_len)
>> + return -EINVAL;
>> +
>> + old = sdata->u.ap.probe_resp;
>
> sparse warns here with RCU checking enabled in the kernel:
>
> cfg.c:502:13: warning: incorrect type in assignment (different address spaces)
> cfg.c:502:13: expected struct sk_buff *old
> cfg.c:502:13: got struct sk_buff [noderef] <asn:4>*probe_resp
>
>
> Please take a look, ieee80211_set_beacon() uses rtnl_dereference() to
> avoid the sparse warning and annotate that the RTNL is used to protect
> the pointer.
>
Thanks. That's indeed a handy .config option.
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
