On Fri, Nov 18, 2011 at 01:12:51PM -0800, Luis R. Rodriguez wrote: > On Fri, Nov 18, 2011 at 1:00 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Fri, 2011-11-18 at 15:54 -0500, John W. Linville wrote: > >> The way the compat-* header files are included causes the default > >> pr_fmt definition from <linux/kernel.h> to be evaluated for every file. > >> Files that define pr_fmt then generate a lot of build SPAM about > >> pr_fmt being redefined. > >> > >> Eliminate the build noise by preemptively undefining pr_fmt in those > >> files that define it. This is accomplished by adding a patch to the > >> patches directory. > > > > This patch is going to be relatively painful when files move etc -- is > > that really worth it? I for one will just drop it in our compat version > > if it goes in since I don't even have all the files it patches :-) > > This may be a good use case for spatch magic? Yeah, I was thinking exactly that. I haven't tried spatch yet, but it would probably handle this fairly well. Are you using it anywhere else? John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
