On Thu, 2011-11-17 at 17:46 -0800, Joe Perches wrote: > Using dev_err instead of dev_printk(KERN_ERR uses fewer > arguments and is a bit smaller. > > Deduplicating formats used by IWL_DEBUG_QUIET_RFKILL also > makes the object a bit smaller. > > Neatened the macros, used ##__VA_ARGS__. > > $ size drivers/net/wireless/iwlwifi/built-in.o* > text data bss dec hex filename > 462652 8646 92576 563874 89aa2 drivers/net/wireless/iwlwifi/built-in.o.new > 467557 8646 92592 568795 8addb drivers/net/wireless/iwlwifi/built-in.o.old > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Acked-by: Wey-Yi Guy <wey-yi.w.guy@xxxxxxxxx> > --- > \ very interesting. Thanks Wey -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html