Search Linux Wireless

Re: [PATCH 2/3] compat: backport kfree_rcu()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/17/2011 11:27 PM, Johannes Berg wrote:
> On Thu, 2011-11-17 at 22:23 +0100, Hauke Mehrtens wrote:
> 
>> +#undef module_exit
>> +#define module_exit(exitfn)						\
> 
>> +	static inline exitcall_t __exittest(void)			\
>> +	{ return exitfn; }						\
> 
> This is not necessary since the exitfn() below will already create a
> compile error if you try module_exit(no_such_function).
This check is not needed, I will remove it. We get the code from the
kernel and it should compile. Most of the tests this function does are
also done by our real function.
> 
>> +	void __exit __exit_compat(void)					\
>> +	{								\
> 
> Shouldn't that be static?
Yes it also works when it is static I changed that.
> 
> johannes
> 
> 

Hauke

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux