Search Linux Wireless

Re: [PATCH] Seeing as alot of ath9k devices is PCI/PCIe or their mini equivalent it makes sense to set ATH9K_PCI to y by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 17 Nov 2011 16:13:53 +0100
Gabor Juhos <juhosg@xxxxxxxxxxx> wrote:

> 2011.11.09. 23:57 keltezéssel, Daniel Kuehn írta:
> > from: Daniel Kuehn <daniel@xxxxxxxx>
> > 
> > Most ath9k devices are PCI/PCIe based, therefor making PCI/PCIe support
> > default y helps those porting a config from 2.6 kernel series
> > from getting "non-functional" wireless drivers with 3.x kernel series.
> > 
> > Signed-off-by: Daniel Kuehn <daniel@xxxxxxxx>
> 
> The option was enabled in the past but it has been removed a few months ago by
> the following commit:
> 
> commit 64bd0821a3b66c3307d7a4ee5523e3e35ec2df0e
> Author: Tao Ma <boyu.mt@xxxxxxxxxx>
> Date:   Wed May 25 09:44:05 2011 +0800
> 
>     wireless: Default to 'n' for 2 new added devices in Kconfig.
> 
>     We make oldconfig every time when a new kernel arrives, but
>     if we don't have such a device(I guess this is the most common
>     case for a new device), the default value should be 'n' so
>     that the kernel size we build doesn't grow up too much quickly.
>     For anyone who has the device, it is OK for them to turn it on
>     by themselves.
> 
>     Cc: "John W. Linville" <linville@xxxxxxxxxxxxx>
>     Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>     Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx>
>     Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
> 
> 
> In my opinion it should not be added again.

I agree with you there if it was removed before, maybe then only the help
section of ath9k should be changed to say that you have to enable either
PCI/PCIe or AHB support for it to work?

Because it doesn't seem to be possible to make it choose that option and still
make it removable IF ath9k is chosen.
It seems you either need to default it to y (with default y) or make it
unremovable if ath9k is selected (with select ATH9K_PCI for ATH9K).

> 
> Regards,
> Gabor

Kind regards,
Daniel Kuehn

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux