On Mon, Nov 14, 2011 at 03:28:18PM +0100, Helmut Schaa wrote:
> @@ -421,8 +421,8 @@ minstrel_ht_tx_status(void *priv, struct ieee80211_supported_band *sband,
> mi->sample_packets += info->status.ampdu_len;
>
> for (i = 0; !last; i++) {
> - last = (i == IEEE80211_TX_MAX_RATES - 1) ||
> - !minstrel_ht_txstat_valid(&ar[i + 1]);
> + last = !minstrel_ht_txstat_valid(&ar[i + 1]) ||
> + (i == IEEE80211_TX_MAX_RATES - 1);
This make possible that we read outsite from ar[] border. Normally
that should not couse any troubles, but I think it could confuse
something like kmemcheck. Perhaps whould be better to just add
unlikely(i == IEEE80211_TX_MAX_RATES - 1) ?
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
