On Wed, 2011-11-16 at 15:40 +0100, Ivo Van Doorn wrote:
> > +static inline void drv_tx_frags(struct ieee80211_local *local,
> > + struct ieee80211_sub_if_data *sdata,
> > + struct sta_info *sta,
> > + struct sk_buff_head *skbs,
> > + void *internal)
> > +{
> > + local->ops->tx_frags(&local->hw,
> > + sdata ? &sdata->vif : NULL,
> > + sta ? &sta->sta : NULL,
> > + skbs, internal);
> > +}
>
> Instead of changing every driver and making .tx_frags callback mandatory,
> isn't it easier to have a if-else here?
We certainly can't have the if-else here, if there should be one it
should be in __ieee80211_tx().
> Then it is much easier for the drivers as you can document that either
> .tx or .tx_frags is mandatory but never both.
Maybe that's the better option. Somehow I thought it would be more
efficient this way, but I guess it doesn't actually make much of a
difference and I can get rid of the void *internal parameter.
I'll change.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
