On Fri, Nov 11, 2011 at 01:03:31PM -0600, Larry Finger wrote: > On 11/11/2011 12:32 PM, John W. Linville wrote: > > CC [M] net/mac80211/cfg.o > >net/mac80211/cfg.c: In function ‘ieee80211_probe_client’: > >net/mac80211/cfg.c:2567:7: warning: ‘qos’ may be used uninitialized in this function > > > >Signed-off-by: John W. Linville<linville@xxxxxxxxxxxxx> > >--- > > net/mac80211/cfg.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > >index c2416fb..1d82d2b 100644 > >--- a/net/mac80211/cfg.c > >+++ b/net/mac80211/cfg.c > >@@ -2564,7 +2564,7 @@ static int ieee80211_probe_client(struct wiphy *wiphy, struct net_device *dev, > > struct sk_buff *skb; > > int size = sizeof(*nullfunc); > > __le16 fc; > >- bool qos; > >+ bool qos = NULL; > > struct ieee80211_tx_info *info; > > struct sta_info *sta; > > Shouldn't the initialization for a bool be "false"? Doesn't > checkpatch.pl complain about that? I know it does if you try to > initialize a pointer to 0 rather than NULL. That's why we post patches to the list. :-) -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html