Search Linux Wireless

Re: [PATCH 17/19] brcm80211: fmac: stop using hard coded firmware/nvram name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 10, 2011 at 08:30:32PM +0100, Arend van Spriel wrote:
> From: Franky Lin <frankyl@xxxxxxxxxxxx>
> 
> The nvram file contains info for firmware which varies with different
> hardware designs. Current nvram file in Linux firmware repository is
> for a internal development board. It is not applicable for any exsisting
> end-user product. Every device with a fullmac support wifi dongle
> should have its own nvram file in the system. Similar rule can be applied
> to the dongle firmware. This patch remove the hard coded firmware/nvram
> name in the driver. The paths of firmware and nvram file must be
> passed to the driver through module parameter during or configured
> in kernel option.
> 
> Reviewed-by: Pieter-Paul Giesberts <pieterpg@xxxxxxxxxxxx>
> Reviewed-by: Arend van Spriel <arend@xxxxxxxxxxxx
> Signed-off-by: Franky Lin <frankyl@xxxxxxxxxxxx>
> Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx>

I can't say that I'm too fond of this one.  Why do you need to be
able to change the name of the file?  Other drivers seem to handle
this without having to set the filename at Kconfig time?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux