On Fri, Nov 4, 2011 at 12:18, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > Add the ability to advertise that the device > contains the AP SME and what features it can > support. > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> [...] > > +/** > + * enum nl80211_ap_sme_features - device-integrated AP features > + * @NL80211_AP_SME_WSC: The driver is capable of indicating received probe > + * request frames to userspace via management frame subscription events > + * if the payload includes the WSC IE. The driver is capable of adding > + * the WSC IE as configured from userspace into beacons, probe responses > + * and (re)association reponse frame and allows userspace to update them > + * during the lifetime of the BSS. > + */ > +enum nl80211_ap_sme_features { > + NL80211_AP_SME_WSC = 1 << 0, > +}; Perhaps we should break up this feature into two? With the upcoming probe-resp patches a wl12xx card will be able to indicate probe-requests with WSC IE up, but won't be able to add a userspace provided WSC IE into beacons. Also I'm wondering what this is used for. For instance this contains no indication about WPS1 and p2p. Pretty sure ath6kl handles these in a similar fashion (at least for the put-IE-from-userspace-in-beacon part). And as a final nit-pick, I think WPS2 is more appropriate, as this is also the name of the option in the hostapd code and config file. Arik -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html