2011/11/3 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Thu, 2011-11-03 at 09:08 +0100, Johannes Berg wrote: > >> > Yes, I see this is set correctly before we call ieee80211_set_qos_hdr(). >> > Next ieee80211_set_qos_hdr() fuction seems not care about EOSP bit and >> > we have this bit cleared before ieee80211_tx() call. >> >> Oh, WTH. Somebody had posted a patch that fixed that, I thought that >> went in but in my testing this didn't show up since my device always >> sets/clears it according to what I told it. > > Try this please. > > johannes > > --- wireless-testing.orig/net/mac80211/wme.c 2011-11-02 11:05:29.000000000 +0100 > +++ wireless-testing/net/mac80211/wme.c 2011-11-03 09:14:30.000000000 +0100 > @@ -143,10 +143,13 @@ void ieee80211_set_qos_hdr(struct ieee80 > /* Fill in the QoS header if there is one. */ > if (ieee80211_is_data_qos(hdr->frame_control)) { > u8 *p = ieee80211_get_qos_ctl(hdr); > - u8 ack_policy = 0, tid; > + u8 ack_policy, tid; > > tid = skb->priority & IEEE80211_QOS_CTL_TAG1D_MASK; > > + /* preserve EOSP bit */ > + ack_policy = *p & IEEE80211_QOS_CTL_EOSP; > + > if (unlikely(sdata->local->wifi_wme_noack_test)) > ack_policy |= IEEE80211_QOS_CTL_ACK_POLICY_NOACK; > /* qos header is 2 bytes */ > > > Verified. Now works correctly. Thanks. BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html