Hi, Arend van Spriel wrote on Sat, Oct 29, 2011: > Though it's unlikely, di may be null, so we can't dereference > di->dma.dmactrlflags until we've checked it. I've got no experience whatsoever in kernel coding so feel free to tell me that's stupid, but if you say it's unlikely why not use the unlikely() macro as well for the check? (also, that's not the point of this patch, but can't hurt to point that out) > if (di == NULL) { would change to if (unlikely(di == NULL)) { Regards, -- Asmadeus | Dominique Martinet -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html