On Thu, 2011-10-27 at 22:11 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> * Allow configuring the mcs (/n) rates available.
> * Allow configuration of MAX-A-MSDU
> * Allow configuration of A-MPDU factor & density.
>
> Users can only remove existing rates. The MSDU and MPDU
> values can be set to any value allowed by the 802.11n
> specification.
That can't work -- the device might not support it.
I also don't really like the way you pass in some binary "mask" when
it's not really a binary masking operation.
> struct vif_params {
> int use_4addr;
> int disable_11n;
> int disable_ht40;
> + struct ieee80211_ht_cap *ht_capa;
> + struct ieee80211_ht_cap *ht_capa_mask;
Same comments as before again -- this is per connection right?
> @@ -114,6 +115,19 @@ static void ieee80211_add_ht_ie(struct sk_buff *skb, const u8 *ht_info_ie,
> if (ht_info_ie[1] < sizeof(struct ieee80211_ht_info))
> return;
>
> + memcpy(&ht_cap, &sband->ht_cap, sizeof(ht_cap));
> + /*
> + * This is for an association attempt, and we must
> + * advert at least the first 8 rates, even if we
> + * will later force the rate control to a lower rate.
> + */
> + ieee80211_apply_htcap_overrides(sdata, &ht_cap, 8);
Yuck, why, why hard-code 8, etc.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
