On Fri, 2011-10-28 at 00:44 +0200, Eliad Peller wrote: > On Thu, Oct 27, 2011 at 9:32 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > For probe responses it can be useful to not wait for ACK > > to save airtime, so allow userspace to request not waiting > > with a new nl80211 flag. > > > > Since mac80211 needs to be updated for the new function > > prototype anyway implement it right away -- it's just a > > few lines of code. > > > > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> > [RFC v2 13/12] ? :) Too lazy to send a new patchset and it really belonged with this :-) > > + if (!dont_wait_for_ack) > > + flags = IEEE80211_TX_CTL_NO_ACK; > > + else > > + flags = IEEE80211_TX_INTFL_NL80211_FRAME_TX | > > + IEEE80211_TX_CTL_REQ_TX_STATUS; > > + > > shouldn't it be the other way around? (i.e. set NO_ACK if dont_wait_for_ack) Doh, of course, thanks. I was editing this code a few times -- guess I lost track. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
