On 10/25/2011 03:05 PM, Vasanthakumar Thiagarajan wrote: > On Tue, Oct 25, 2011 at 02:43:11PM +0300, Kalle Valo wrote: >> On 10/25/2011 01:10 PM, Vasanthakumar Thiagarajan wrote: >>> Configuring the firmware for three interfaces causes random >>> target assert. So restrict the number of vifs to just 1 to avoid >>> this issue for now. Once it is fixed in firmware, this patch >>> would be reverted. >> >> Patches 32-34 are problematic. They are changing functionality of >> patches earlier in the series. (I guess you created those patches >> later.) Instead you should edit the original patches, not just add >> extra patches on top. > > Patch 32 and 33 are clean ups, i don't think integrating these > changes into respective patches would be trivial with the number of > patches that need to be rebased after the change. Yeah, that's always a problem when you are sending a huge patchset like this. A solution for this is to work split work to smaller patches, that way changes in patches would cause less work. > So I can drop these two patches and send them sometime later. Dropping doesn't make any difference here actually, still the original code needing for cleanup will stay in the history. > Regarding patch 34, the target configuration changes needed for multi > vif are done in more than one patches and integrating this change > into those changes would not make sense to those configurations. Let > me see how I can integrate this. Thanks. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
