Search Linux Wireless

Re: [RFC 1/2] mac80211: fix remain_off_channel regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi Ben,

On Wed, Oct 19, 2011 at 8:03 PM, Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:
> On 07/25/2011 08:29 AM, Eliad Peller wrote:
>>
>> i'm not familiar enough with the off_channel flow,
>> but this one looks completely broken - we should
>> remain_off_channel if the work was started, and
>> the work's channel and channel_type are the same
>> as local->tmp_channel and local->tmp_channel_type.
>>
>> however, if wk->chan_type and local->tmp_channel_type
>> coexist (e.g. have the same channel type), we won't
>> remain_off_channel.
>>
>> this behavior was introduced by commit da2fd1f
>> ("mac80211: Allow work items to use existing
>> channel type.")
>>
>> Signed-off-by: Eliad Peller<eliad@xxxxxxxxxx>
>
> Both Johannes and I agreed with this patch shortly after it
> was posted, and I have just done a quick test with multiple
> stations and it appears to work fine.
>
> Eliad:  Please re-send this patch w/out the RFC, and you
> can add:
>
> Tested-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
it seems that i forgot to resubmit the RFCs as patches.
thanks for testing, i'll submit them shortly.

(John - i see there is some ongoing discussion regarding similar
patches, so feel free to take only some of them, according to the
conclusion)

Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux