On Sun, 16 Oct 2011 23:23:56 +0200 Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > + if (phy->type >= B43_PHYTYPE_N) { I must say that I really dislike this. It's error prone (previous patch got it wrong) and it's hard to read. Just spell out all types or use a switch statement, as appropriate. It also makes grepping the sources a lot harder. I don't see any real advantage. -- Greetings, Michael. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html