On Fri, Oct 14, 2011 at 11:30 AM, Loiseau Lucien <loiseau.lucien@xxxxxxxxx> wrote: > Digging into the source code, i noticed that the documentation tells that > the tx function from ieee80211_ops should return NETDEV_TX_OK while the tx > function is now a void function. This is good, but as presented, you've left the job for others to make the patch suitable for applying to the kernel. Please see Documentation/SubmittingPatches for more info. For example, a better email / commit message might be: [PATCH] mac80211: remove reference to NETDEV_TX_OK The kerneldoc states that ieee80211_ops.tx must return NETDEV_TX_OK, but tx is now a void function. Remove the stale comment. Signed-off-by: <your-s-o-b-here> --- [patch goes here] It's almost the same as what you wrote, but there is a Signed-off-by, and the subject and description are fit for the long term kernel history. If you perform these few extra steps when submitting, John can just queue your patch directly from his inbox, and you get to keep all the credit. If you make the maintainer's job hard, he might drop it on the floor until someone else does the work. -- Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
