On 10/14/2011 05:11 PM, Pavel Roskin wrote: > On Sat, 08 Oct 2011 17:28:42 -0500 > Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote: > >> +static inline void htol16_buf(u16 *buf, unsigned int size) >> +{ >> + size /= 2; >> + while (size--) >> + *(__le16 *)(buf + size) = cpu_to_le16(*(buf + size)); >> } > > I'm not not sure compilers would optimize it out on little-endian > systems. Perhaps you want a define that uses this code on > big-endian systems and does nothing on little endian systems. > > Also, it would be nice to have a compile-time check that size is even. > Or maybe size should be the number of 16-bit words, but then it would be > better to call the argument "count" or something like that. > I think this patch was already dropped. Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html