W dniu 13 października 2011 00:22 użytkownik Sedat Dilek
<sedat.dilek@xxxxxxxxxxxxxx> napisał:
> 2011/10/12 Rafał Miłecki <zajec5@xxxxxxxxx>:
>> This reverts commit 55ad5962e97430c83d51df36fc18865ee4f78c48.
>>
>> I assumed N is newer than LP, which isn't true. This regressed LP case.
>>
>> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx>
>> ---
>> It seems that wasn't so "trivial", sorry for this regression :|
>> ---
>> drivers/net/wireless/b43/xmit.c | 12 +++++-------
>> 1 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/xmit.c b/drivers/net/wireless/b43/xmit.c
>> index 5f812d1..b8de62c 100644
>> --- a/drivers/net/wireless/b43/xmit.c
>> +++ b/drivers/net/wireless/b43/xmit.c
>> @@ -735,13 +735,11 @@ void b43_rx(struct b43_wldev *dev, struct sk_buff *skb, const void *_rxhdr)
>> }
>>
>> /* Link quality statistics */
>> - if ((chanstat & B43_RX_CHAN_PHYTYPE) >= B43_PHYTYPE_N) {
>> - /*
>> - s8 rssi = max(rxhdr->power0, rxhdr->power1);
>> - TODO: Find out what the rssi value is (dBm or percentage?)
>> - and also find out what the maximum possible value is.
>> - Fill status.ssi and status.signal fields.
>> - */
>> + if ((chanstat & B43_RX_CHAN_PHYTYPE) == B43_PHYTYPE_N) {
>> +// s8 rssi = max(rxhdr->power0, rxhdr->power1);
>> + //TODO: Find out what the rssi value is (dBm or percentage?)
>> + // and also find out what the maximum possible value is.
>> + // Fill status.ssi and status.signal fields.
>> } else {
>> status.signal = b43_rssi_postprocess(dev, rxhdr->jssi,
>> (phystat0 & B43_RX_PHYST0_OFDM),
>> --
>> 1.7.3.4
>>
>
> Commenting style?
> Isn't C99-like commenting not well seen?
This is simple revert, the code was like that before my patch.
My 2/2 patch remove that ugly commenting style.
--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
