On 10/12/2011 08:29 AM, Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/net/wireless/brcm80211/brcmutil/utils.c:20:15: error: expected declaration specifiers or '...' before string constant > drivers/net/wireless/brcm80211/brcmutil/utils.c:21:20: error: expected declaration specifiers or '...' before string constant > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int] > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: parameter names (without types) in function declaration [enabled by default] > > Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers") > from the wireless tree interacting with the module.h split up. > > These files clearly should include module.h (John, please apply this to the > wireless tree): > > From d89b14ffc84a2b8a54ffe89453b8bbf9cabf1468 Mon Sep 17 00:00:00 2001 > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Date: Wed, 12 Oct 2011 17:07:06 +1100 > Subject: [PATCH] net: wireless: brcm80211: include module.h > > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Hi John, Do you intend to take this patch as well. I used it to prepare the patch series I sent earlier titled "[PATCH 00/22] brcm80211: mainline patch related cleanup" identified by: Message-ID: <1318445492-24207-1-git-send-email-arend@xxxxxxxxxxxx> Gr. AvS ps: If you want the bare patch file, I still have it on disk here. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html