On Wed, 2011-10-12 at 03:02 +0200, Dmitry Tarnyagin wrote: > From: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> > Date: Thu, 4 Aug 2011 11:42:16 +0200 > > P2P power save support: > - Opportunistic Power Save > - Notice Of Absence More explanation please. I know I sound like a broken record but for such a big change you really need more text. I'm not even going to bother to review the patch in detail. You need to explain why you need to set NoA. There are three reasons this would be used: 1) actually save power 2) do scanning, multi-channel operation, etc. 3) P2P certification testing Only 3) seems to be useful from userspace, and then maybe it shouldn't be full-blown nl80211 API. Similarly for the P2P power save stuff. Since you generally lack documentation updates in your patches (read this as criticism) there's no way reason to even look through your patches since they don't explain anything. FWIW, a very brief glance over this patch tells me that there's at least one obvious, glaring bug in it. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
