Hi Dmitry,
Some minor comments on this patch:
Note that I'm not a maintainer and that these are comments on the
patch itself, not the code it adds.
That said, it's nice to see someone updating compat-wireless when they
update the main wireless repository.
On Wed, Oct 12, 2011 at 12:02, Dmitry Tarnyagin <abi.dmitryt@xxxxxxxxx> wrote:
> From: Bartosz Markowski <bartosz.markowski@xxxxxxxxx>
> Date: Tue, 12 Jul 2011 13:29:03 +0200
> Subject: [PATCH 2/7] compat-wireless: CQM STE extensions
>
> added:
> * beacon miss threshold - This value specifies the threshold
> for the BEACON loss level
> * tx fail - This value specifies the threshold for the TX loss level
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@xxxxxxxxx>
> ---
> include/linux/compat-3.0.h | 2 +
> include/linux/nl80211.h | 16 +++++
> include/net/cfg80211.h | 34 ++++++++++
> include/net/mac80211.h | 41 ++++++++++++
> net/mac80211/cfg.c | 54 ++++++++++++++++
> net/mac80211/mlme.c | 23 ++++++-
> net/wireless/mlme.c | 25 +++++++
> net/wireless/nl80211.c | 152
> +++++++++++++++++++++++++++++++++++++++++++-
> net/wireless/nl80211.h | 9 +++
You are changing a lot of files that are not actually part of the
compat-wireless git repository - are you sure that this patch is
correct?
> diff --git a/include/linux/compat-3.0.h b/include/linux/compat-3.0.h
> index 8c8720e..961a3a6 100644
> --- a/include/linux/compat-3.0.h
> +++ b/include/linux/compat-3.0.h
> @@ -59,6 +59,7 @@ int __must_check kstrtos16_from_user(const char __user *s,
> size_t count, unsigne
> int __must_check kstrtou8_from_user(const char __user *s, size_t count,
> unsigned int base, u8 *res);
> int __must_check kstrtos8_from_user(const char __user *s, size_t count,
> unsigned int base, s8 *res);
>
> +/*
> static inline int __must_check kstrtou64_from_user(const char __user *s,
> size_t count, unsigned int base, u64 *res)
> {
> return kstrtoull_from_user(s, count, base, res);
> @@ -78,6 +79,7 @@ static inline int __must_check kstrtos32_from_user(const
> char __user *s, size_t
> {
> return kstrtoint_from_user(s, count, base, res);
> }
> +*/
Why are you commenting out this function?
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
