On Mon, Oct 10, 2011 at 10:38 PM, Luciano Coelho <coelho@xxxxxx> wrote: > On Mon, 2011-10-10 at 10:13 +0200, Eliad Peller wrote: >> add band field into the per-interface data. >> >> mac80211 configures some values (e.g. band, channel) >> globally, while we configure them per-interface. >> >> In order to make it easier to keep track of the >> configured value for each value while keeping sync >> with mac80211, save these values both globally >> and per-vif. >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> --- > > [...] > > >> -static int wl12xx_cmd_roc(struct wl1271 *wl, u8 role_id) >> +static int wl12xx_cmd_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif, >> + u8 role_id) > > [...] > >> -int wl12xx_roc(struct wl1271 *wl, u8 role_id) >> +int wl12xx_roc(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 role_id) > > Seems like wl12xx_roc(), which is the only caller of wl12xx_cmd_roc(), > is always called with wlvif->role_id as the role, so it seems a bit > useless to pass role_id separately all the way. > in fact, it's usually being called with wlvif->dev_role_id, so we do need this param. (otoh, wl12xx_roc is usually get called along with start_role_dev. i have some pending patch that couples them together and cleans the code a bit. i'll send it soon). Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
