On Mon, 2011-10-10 at 21:36 +0200, Eliad Peller wrote: > On Mon, Oct 10, 2011 at 8:58 PM, Luciano Coelho <coelho@xxxxxx> wrote: > > On Mon, 2011-10-10 at 10:12 +0200, Eliad Peller wrote: > >> Some events don't indicate the role they are intended for. > >> In these cases, iterate through all the relevant vifs, > >> and pass the event to each one of them. > >> > >> This is only a workaround. future fw releases should indicate > >> the relevant role_id for such events. > >> > >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> > >> --- > > > > Is this workaround really necessary? Are we going to have a firmware > > that supports multi-role but does *not* pass the role_id for these > > events? > > > i hope not. :) > but in the meantime, we use this workaround to keep compatibility with > the current (single-role) fw. What I meant is that you could keep this global, without moving it temporarily to the wlvif and traversing the list, which has always only a single element anyway. But now I see that you want to get rid of the global wl->vif, so it's fine. It's only the list traversal that is actually a workaround, the rest of the changes are actually fine. -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
