On Mon, Oct 10, 2011 at 8:20 PM, Luciano Coelho <coelho@xxxxxx> wrote: > On Mon, 2011-10-10 at 10:12 +0200, Eliad Peller wrote: >> move bitrate_masks into the per-interface data, rather than >> being global. >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> --- > > [...] > >> diff --git a/drivers/net/wireless/wl12xx/cmd.c b/drivers/net/wireless/wl12xx/cmd.c >> index 102a8a5..ff653e8 100644 >> --- a/drivers/net/wireless/wl12xx/cmd.c >> +++ b/drivers/net/wireless/wl12xx/cmd.c >> @@ -1111,15 +1111,16 @@ out: >> return ret; >> } >> >> -int wl1271_cmd_build_probe_req(struct wl1271 *wl, >> +int wl1271_cmd_build_probe_req(struct wl1271 *wl, struct wl12xx_vif *wlvif, >> const u8 *ssid, size_t ssid_len, >> const u8 *ie, size_t ie_len, u8 band) > > If struct wl12xx_vif contains a pointer to wl, can't you pass only wlvif > to all these functions instead of passing both? > yes, it's possible. but maybe leave it for some future overhaul? Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html