-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/09/2011 10:48 AM, Rafał Miłecki wrote: > Agree. I already tried converting bcma to use crc8: > [RFC][WORTH IT?][PATCH] bcma: make use of crc8 lib > http://lists.infradead.org/pipermail/b43-dev/2011-June/001466.html > > But resigned, it was introducing some hacks or not optimal ops, I > decided it's not worth it. > > Even Arend said their brcm80211 is hacky about crc8 usage: > > W dniu 15 czerwca 2011 21:26 użytkownik Arend van Spriel > <arend@xxxxxxxxxxxx> napisał: >> Agree. In brcm80211 we convert the entire sprom, calculate, and convert it >> back. Also not perfect I think as it loops over de sprom data twice. > Hi Rafał, "not perfect" == "hacky" ;-) I also just replied with a less hacky approach. Reading the sprom as bytes will read the sprom content as is (little-endian) and you can do the crc8 check without any conversions. After the check there is only one conversion needed to move to a word array. Gr. AvS -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOkXheAAoJELcEx/G14aEWnHwP+wZRWLladazO/zZnuMrnEuRk xhMzbZcIy8gJwkGs/GwuWqnHBZu+Qx/k/BC3S1CNNmLPOf7qLNbS4hgKRZn+2Tze FHYzXb6IPXkCE6MS5BFRi2qxnzrxam7gL00SB5NuGceS4b3LQL+wNHzPx5yPlPEW KsJnecyFTabclun2zxucZPB19w2xrS84Xcl2Db+2nV3wSn700REr5mr3+pmVXmvd ptLuWsc5ZoAnvuTQq/PUjKvQb/tA7CpDFs9+uvCeKa93Rb3JIRwTk5tAVadLEWn7 6IWyN0VMK+pdL2LT14qc1LWJa192tn8qbmOg21lKsQFepP4egJyRGWaU7aKo9bdG PVSXfqme0azRl6vd+G28Q/SVdt//w5HBoPgdWlORhNdo/sov07QVl8gf80QkTn/A Ij3M1+LMlUFu7weuIwgKBIA+Bi6CxTR/3ozK+S3ItpVqt6gCnMlDYtEUM6pk2vVj 8ppl0LtGHyrogFgwOrcYbxMKJGbk8Po82T+Um7wchcHuRxGLD3NuErndMiRwemMk zALNLYNCLLftCSypCgkM5kyfDkDf7uZMxJZbPXyIIFCP4BXm5xrgx39sYQAVx4if bIjW0W3OmIbBcQScZ4+KRZ5YN1g45VFRQ3+4BPyusApYqzwSmjxUj8aomfD2QhEJ Fh/5uq3JIrpQazyEsILz =JjZ0 -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
