On Fri, Oct 7, 2011 at 12:54 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2011-10-04 at 16:47 -0700, Luis R. Rodriguez wrote:
>
>> /**
>> + * enum nl80211_dfs_regions - regulatory DFS regions
>> + *
>> + * @NL80211_DFS_UNSET: Country has no DFS master region specified
>> + * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
>> + * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
>> + * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
>> + */
>> +enum nl80211_cflags {
>> + NL80211_DFS_UNSET = 0,
>
> That seems odd -- nl80211 convention would be to just leave out the
> attribute.
I wonder what seems more odd, having that present or looking at this:
+bool reg_supported_dfs_region(u8 dfs_region)
+{
+ switch (dfs_region) {
+ case 0:
+ case NL80211_DFS_FCC:
+ case NL80211_DFS_ETSI:
+ case NL80211_DFS_JP:
+ return true;
+ default:
+ REG_DBG_PRINT("Ignoring uknown DFS master region: %d\n",
+ dfs_region);
+ return false;
+ }
+}
Vs:
+bool reg_supported_dfs_region(u8 dfs_region)
+{
+ switch (dfs_region) {
+ case NL80211_DFS_UNSET:
+ case NL80211_DFS_FCC:
+ case NL80211_DFS_ETSI:
+ case NL80211_DFS_JP:
+ return true;
+ default:
+ REG_DBG_PRINT("Ignoring uknown DFS master region: %d\n",
+ dfs_region);
+ return false;
+ }
+}
You pick, you're the maintainer.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
