On 10/03/2011 08:27 PM, Luis R. Rodriguez wrote: > On Mon, Oct 3, 2011 at 3:29 AM, Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> wrote: >> >> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> >> --- >> drivers/net/wireless/ath/ath9k/main.c | 12 ++++++++++++ >> 1 files changed, 12 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c >> index e8aeb98..5defebe 100644 >> --- a/drivers/net/wireless/ath/ath9k/main.c >> +++ b/drivers/net/wireless/ath/ath9k/main.c >> @@ -344,6 +344,18 @@ static int ath_reset_internal(struct ath_softc *sc, struct ath9k_channel *hchan, >> "Unable to reset channel, reset status %d\n", r); >> goto out; >> } >> +#ifdef CONFIG_ATH9K_DFS >> + /** >> + * enable radar pulse detection >> + * >> + * TODO: do this only for DFS channels >> + */ >> + ah->private_ops.set_radar_params(ah, &ah->radar_conf); >> + ath9k_hw_setrxfilter(ah, >> + ath9k_hw_getrxfilter(ah) | ATH9K_RX_FILTER_PHYRADAR); >> + ath_dbg(common, ATH_DBG_DFS, >> + "DFS enabled for channel %d\n", hchan->chan->center_freq); >> +#endif > > Please spare the #ifdef and just call something within dfs.c, then > dfs.h would wrap it to nothing if DFS is disabled. > This possibly won't work, since setting up DFS registers is part of HW layer and not done in the dfs module. If you want to have DFS conditionally compilable, you can not spare this #ifdefs. But I see that this would work in patch 6/6 when calling ath9k_dfs_process_phyerr() on ATH9K_PHYERR_RADAR. Will be considered. > Luis Thanks, Zefir -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
