On Monday, October 03, 2011 08:27:39 PM Luis R. Rodriguez wrote: > On Mon, Oct 3, 2011 at 3:29 AM, Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> wrote: > > > > Signed-off-by: Zefir Kurtisi <zefir.kurtisi@xxxxxxxxxxx> > > --- > > drivers/net/wireless/ath/ath9k/main.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c > > index e8aeb98..5defebe 100644 > > --- a/drivers/net/wireless/ath/ath9k/main.c > > +++ b/drivers/net/wireless/ath/ath9k/main.c > > @@ -344,6 +344,18 @@ static int ath_reset_internal(struct ath_softc *sc, struct ath9k_channel *hchan, > > "Unable to reset channel, reset status %d\n", r); > > goto out; > > } > > +#ifdef CONFIG_ATH9K_DFS > > + /** > > + * enable radar pulse detection > > + * > > + * TODO: do this only for DFS channels > > + */ > > + ah->private_ops.set_radar_params(ah, &ah->radar_conf); > > + ath9k_hw_setrxfilter(ah, > > + ath9k_hw_getrxfilter(ah) | ATH9K_RX_FILTER_PHYRADAR); > > + ath_dbg(common, ATH_DBG_DFS, > > + "DFS enabled for channel %d\n", hchan->chan->center_freq); > > +#endif > > Please spare the #ifdef and just call something within dfs.c, then > dfs.h would wrap it to nothing if DFS is disabled. Why would anyone want to disable DFS driver support? I would say: drop the ifdefs altogether since DFS is and will be "required". Regards, Chr -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
