On Fri, Sep 30, 2011 at 10:57 PM, John W. Linville
<linville@xxxxxxxxxxxxx> wrote:
> On Sun, Sep 25, 2011 at 08:06:55PM +0300, Eliad Peller wrote:
>> tx params should be configured per interface.
>> Add ieee80211_vif param to the conf_tx callback,
>> and update all the drivers that use this callback.
>>
>> The following spatch was used:
>> @rule1@
>> struct ieee80211_ops ops;
>> identifier conf_tx_op;
>> @@
>> ops.conf_tx = conf_tx_op;
>>
>> @rule2@
>> identifier rule1.conf_tx_op;
>> identifier hw, queue, params;
>> @@
>> conf_tx_op (
>> - struct ieee80211_hw *hw,
>> + struct ieee80211_hw *hw, struct ieee80211_vif *vif,
>> u16 queue,
>> const struct ieee80211_tx_queue_params *params) {...}
>>
>> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
>
> CC [M] drivers/net/wireless/mwl8k.o
> drivers/net/wireless/mwl8k.c: In function ‘mwl8k_reload_firmware’:
> drivers/net/wireless/mwl8k.c:5466:3: warning: passing argument 2 of ‘mwl8k_conf_tx’ makes pointer from integer without a cast
> drivers/net/wireless/mwl8k.c:4918:12: note: expected ‘struct ieee80211_vif *’ but argument is of type ‘int’
> drivers/net/wireless/mwl8k.c:5466:3: warning: passing argument 3 of ‘mwl8k_conf_tx’ makes integer from pointer without a cast
> drivers/net/wireless/mwl8k.c:4918:12: note: expected ‘u16’ but argument is of type ‘struct ieee80211_tx_queue_params *’
> drivers/net/wireless/mwl8k.c:5466:3: error: too few arguments to function ‘mwl8k_conf_tx’
> drivers/net/wireless/mwl8k.c:4918:12: note: declared here
> make[1]: *** [drivers/net/wireless/mwl8k.o] Error 1
> make: *** [drivers/net/wireless/] Error 2
>
> Feel free to submit a new patch that doesn't introduce warnings or break the build...
>
sorry for the mess.
in fact, i did selected and compile-tested all the drivers, but as my
.config didn't define CONFIG_PCI, i missed some of them...
as Johannes noted, the actual problem was that spatch failed where the
function definition and the function use span over multiple files.
i'll rebase, fix it, and send a new version soon.
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
