On Mon, 2011-09-26 at 13:54 +0300, Arik Nemtsov wrote:
> @@ -876,6 +884,8 @@ static int nl80211_send_wiphy(struct sk_buff *msg, u32 pid, u32 seq, int flags,
> }
> CMD(set_channel, SET_CHANNEL);
> CMD(set_wds_peer, SET_WDS_PEER);
> + CMD(tdls_mgmt, TDLS_MGMT);
Should that maybe depend on the TLDS_EXTERNAL_SETUP flag to avoid
inconsistencies? Especially with mac80211 drivers?
> + CMD(tdls_oper, TDLS_OPER);
and maybe not advertise that if TDLS isn't support -- in particular so
that mac80211 drivers don't advertise it even though mac80211 might have
the hook.
> +static int nl80211_tdls_mgmt(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct cfg80211_registered_device *rdev = info->user_ptr[0];
> + struct net_device *dev = info->user_ptr[1];
> + u8 action_code, dialog_token;
> + u16 status_code;
> + u8 *peer;
> +
> + if (!rdev->ops->tdls_mgmt)
> + return -EOPNOTSUPP;
> +
> + if (!info->attrs[NL80211_ATTR_TDLS_ACTION] ||
> + !info->attrs[NL80211_ATTR_STATUS_CODE] ||
> + !info->attrs[NL80211_ATTR_TDLS_DIALOG_TOKEN] ||
> + !info->attrs[NL80211_ATTR_IE] ||
> + !info->attrs[NL80211_ATTR_MAC])
> + return -EINVAL;
> +
> + peer = nla_data(info->attrs[NL80211_ATTR_MAC]);
> + action_code = nla_get_u8(info->attrs[NL80211_ATTR_TDLS_ACTION]);
> + status_code = nla_get_u16(info->attrs[NL80211_ATTR_STATUS_CODE]);
> + dialog_token = nla_get_u8(info->attrs[NL80211_ATTR_TDLS_DIALOG_TOKEN]);
> +
> + return rdev->ops->tdls_mgmt(&rdev->wiphy, dev, peer, action_code,
> + dialog_token, status_code,
> + nla_data(info->attrs[NL80211_ATTR_IE]),
> + nla_len(info->attrs[NL80211_ATTR_IE]));
> +}
Shouldn't that return an error if TDLS_EXTERNAL_SETUP isn't set? At
least for some operations?
> +static int nl80211_tdls_oper(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct cfg80211_registered_device *rdev = info->user_ptr[0];
> + struct net_device *dev = info->user_ptr[1];
> + enum nl80211_tdls_operation operation;
> + u8 *peer;
> +
> + if (!rdev->ops->tdls_oper)
> + return -EOPNOTSUPP;
> +
> + if (!info->attrs[NL80211_ATTR_TDLS_OPERATION] ||
> + !info->attrs[NL80211_ATTR_MAC])
> + return -EINVAL;
> +
> + operation = nla_get_u8(info->attrs[NL80211_ATTR_TDLS_OPERATION]);
> + peer = nla_data(info->attrs[NL80211_ATTR_MAC]);
> +
> + return rdev->ops->tdls_oper(&rdev->wiphy, dev, peer, operation);
> +}
Ditto here, if TDLS isn't supported it needs to return an error I think,
and if TLDS needs external setup it needs to return errors for the setup
operations I think?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
