Search Linux Wireless

Re: [PATCH 1/1] rfkill: add module option to become inactive.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-09-27 at 12:03 +0400, Andrew V. Stepanov wrote:
> On Tue, Sep 27, 2011 at 11:46 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Tue, 2011-09-27 at 14:33 +0400, Andrew V. Stepanov wrote:
> >> From: Andriy Stepanov <stanv@xxxxxxxxxxx>
> >>
> >> Use as:
> >> modprobe rfkill unblocked=1
> >> or
> >> /etc/modprobe.d/options
> >> options rfkill unblocked=1
> >
> > Apart from the obvious style problems in this patch (tons of extra
> > braces) I'm not convinced this is a good idea.
> >
> > What problem does it solve? Why can that problem not be solved
> > differently with existing mechanisms (e.g. urfkilld configured to do
> > nothing)?

> 2. urfkilld  can't be used to ignore Hard blocked buttons.

Oh that's a good point -- so NACK on the patch.

You *can't* ignore hard block buttons. All you can ignore is events from
them, which is definitely not useful.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux