On Thu, 2011-09-22 at 20:28 +0530, Rajkumar Manoharan wrote: Looks fine, minor nitpick: > + request->no_cck = nla_get_flag(info->attrs > + [NL80211_ATTR_TX_NO_CCK_RATE]); I think that'd be nicer as request->no_cck = nla_get_flag(...); even if potentially that goes above 80 cols. > + no_cck = nla_get_flag(info->attrs[NL80211_ATTR_TX_NO_CCK_RATE]); Or I guess it probably won't if this fits :) Thanks! johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html